chore(registry): add branding to glama.json + server.json (INS-306)#63
Merged
Conversation
Add schema-defined branding fields to the MCP registry manifest so the registry entry surfaces a website and icon. Both fields are validated by the official MCP server.schema.json (2025-12-11). - server.json: add websiteUrl (https://insforge.dev) and icons[] (https://github.com/InsForge.png, image/png). glama.json was left unchanged: its published schema (https://glama.ai/mcp/schemas/server.json) defines only `maintainers` and no branding fields, so no valid field could be added there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesServer Metadata Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file
Linked issue analysis
Linked issue: INS-306: Raise ora Agent Readiness Score (59 C → A): ship Discovery + Agent Integration quick wins
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Add icons to insforge-mcp server.json (registry manifest includes an icons array with a valid HTTPS src and mimeType). | The diff adds an icons array with src = https://github.com/InsForge.png and mimeType = image/png, which matches the MCP schema constraints mentioned in the PR. |
| ✅ | Add websiteUrl to insforge-mcp server.json (manifest exposes a website/homepage URL). | The diff adds websiteUrl: https://insforge.dev to server.json, which is the schema-approved field the PR said it would add. |
| ✅ | Do not invent unsupported branding fields in glama.json (leave glama.json unchanged when its published schema does not define branding fields). | The PR explicitly leaves glama.json unmodified because the published Glama schema defines only maintainers and has no logo/website/description properties; this avoids adding non-standard fields. |
| ✅ | Validate the updated server.json against the official MCP server.schema.json. | The PR states the updated server.json was validated with ajv against the official MCP schema and that validation passed; the added fields conform to the schema's requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Metadata hygiene for INS-306 (ora "Registry branding 0/2" — MCP registry entry lacks display name/icon/website). Fills in blank branding fields on the registry manifests, adding only fields that are valid per each manifest's schema (schemas verified by fetching them before editing).
Fields added
server.json— validated against the official MCPserver.schema.json(https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json, the$schemaalready referenced in the file). Validated with ajv: passes.websiteUrl:https://insforge.dev— schema defineswebsiteUrl("Optional URL to the server's homepage…").icons:[{ "src": "https://github.com/InsForge.png", "mimeType": "image/png" }]— schema definesicons(array ofIcon;srcrequires an HTTPS URI ≤255 chars,mimeTypeenum includesimage/png). The logo URL resolves to a200 image/png(the InsForge GitHub org avatar).Unchanged in
server.json:name,version,packages,remotes,title,description,repository.glama.json— not modified. The Glama schema (https://glama.ai/mcp/schemas/server.json) defines exactly one property:maintainers. It defines nodescription,logo/icon, orwebsitefield. Rather than invent unrecognized fields, glama.json was left as-is. The website/icon branding is carried byserver.json, where it is schema-defined.Notes / honesty
description/logo/websitefields — its published schema does not, so those were intentionally omitted to avoid inventing fields. If Glama later publishes a richer schema, a follow-up can add them.package.json1.2.10 vsserver.json1.2.6) was left untouched per scope.🤖 Generated with Claude Code
Summary by cubic
Add branding to the MCP registry manifest so our entry shows a website and icon in registries, contributing to INS-306’s Agent Readiness goals.
Adds
websiteUrlandicons[]toserver.jsonper the MCP schema; leavesglama.jsonunchanged because its schema has no branding fields.Written for commit 2b44b19. Summary will update on new commits.
Summary by CodeRabbit